Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalization for all REST API #295

Closed
wants to merge 4 commits into from

Conversation

gcusnieux
Copy link

Recovery enctype of the form, remove the static 'multipart/form'.. there may be other types such as 'multipart/related' & taking into account the contentType 'options' because for some REST API, the contentType is mandatory

…ere may be other types such as 'multipart/related' & taking into account the contentType 'options' because for some REST API, the contentType is mandatory
@malsup
Copy link
Collaborator

malsup commented Mar 1, 2013

Can you provide a cleaner patch that doesn't reformat the entire file?

Guillaume Cusnieux added 3 commits March 1, 2013 15:54
…tipart/form'.. there may be other types such as 'multipart/related' & taking into account the contentType 'options' because for some REST API, the contentType is mandator
…tipart/form'.. there may be other types such as 'multipart/related' & taking into account the contentType 'options' because for some REST API, the contentType is mandator
@hugohenrique
Copy link

ping

@kevindb
Copy link
Contributor

kevindb commented Mar 6, 2017

@gcusnieux, I have a few questions for you about this PR:

  1. Can you provide documentation about other possible values for the form enctype attribute? MDN docs only list three: application/x-www-form-urlencoded, multipart/form-data, and text/plain.
  2. What is the significance of checking the value of an encoding attribute on the form (line 181)? I haven't been able to find any documentation that it is a valid attribute for the form tag.
  3. Why did you remove the contentType default (false) from line 255?

@kevindb
Copy link
Contributor

kevindb commented Apr 11, 2017

I am closing this PR for now. It can be reopened if there is demand for this feature.

@kevindb kevindb closed this Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants