Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment creation fails if environment.yml file has comments at top of file #81

Closed
GBBBAS opened this issue Jun 12, 2023 · 3 comments · Fixed by #82
Closed

Environment creation fails if environment.yml file has comments at top of file #81

GBBBAS opened this issue Jun 12, 2023 · 3 comments · Fixed by #82
Labels
bug Something isn't working

Comments

@GBBBAS
Copy link

GBBBAS commented Jun 12, 2023

Hi,

Recently, this github action started failing for my pipeline where it used to work before with the following error:
Error: Could not determine environment name from file environment.yml

Example:
https://github.com/rtdip/core/actions/runs/5241275225/jobs/9463153612

I have identified that this occurs when there are comments at the top of the file. When I remove the comments, the environment install works.

Did something change in this github action that causes this to now happen? Ultimately we need to have copyright headers at the top of the file, so would like this to work.

@pavelzw pavelzw added the bug Something isn't working label Jun 12, 2023
@pavelzw
Copy link
Member

pavelzw commented Jun 12, 2023

Hmm, this may have something to do with #79 which I released three days ago. I'll look into it.

@pavelzw
Copy link
Member

pavelzw commented Jun 12, 2023

Thanks for the quick issue! I fixed it in #82 and added a unit test covering your case.

@GBBBAS
Copy link
Author

GBBBAS commented Jun 12, 2023

Awesome, thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants