Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.1 Support #39

Closed
SerafimArts opened this issue Jul 16, 2018 · 2 comments
Closed

PHP 7.1 Support #39

SerafimArts opened this issue Jul 16, 2018 · 2 comments

Comments

@SerafimArts
Copy link

Environment:

  • phpda 1.3.1
  • php 7.2
  • Linux

Actual:

Done

Logs:
Error	Syntax error, unexpected '?' on line 35 ./src/Contracts/Definition/Behaviour/ProvidesArguments.php
Error	Syntax error, unexpected '?' on line 35 ./src/Contracts/Definition/Behaviour/ProvidesFields.php
Error	Syntax error, unexpected '?' on line 36 ./src/Contracts/Definition/Behaviour/ProvidesInputFields.php
Error	Syntax error, unexpected '?' on line 34 ./src/Contracts/Definition/Behaviour/ProvidesInterfaces.php
Error	Syntax error, unexpected '?' on line 28 ./src/Contracts/Definition/Behaviour/ProvidesLocations.php
Error	Syntax error, unexpected '?' on line 25 ./src/Contracts/Definition/Behaviour/ProvidesSchema.php
Error	Syntax error, unexpected T_CONST, expecting T_FUNCTION on line 22 ./src/Contracts/Definition/Dependent/DirectiveLocation.php
Error	Syntax error, unexpected '?' on line 34 ./src/Contracts/Definition/EnumDefinition.php
Error	Syntax error, unexpected T_CONST, expecting T_FUNCTION on line 20 ./src/Contracts/Definition/SchemaDefinition.php
Error	Syntax error, unexpected '?' on line 34 ./src/Contracts/Invocation/Behaviour/ProvidesPassedArguments.php
Error	Syntax error, unexpected T_CONST, expecting T_FUNCTION on line 20 ./src/Contracts/Type.php

Files example:

    public function getArgumentDefinition(string $name): ?ArgumentDefinition; // Error on this line (return typehint)

Expected:

OK
@Pierstoval
Copy link

Is there any move on this? For documentation/educational purposes, I would definitely need a tool like this, but without PHP 7.1+ support it becomes tedious to generate a dependency graph for classes, since there's not many tools for this purpose...

@mamuz If you ever need help, can you give hints on where to start for people that never contributed to this project? 😉

@mamuz
Copy link
Owner

mamuz commented Apr 10, 2019

will be fixed with next major

@mamuz mamuz closed this as completed Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants