Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove the ARCTICDB_USING_CONDA and the ARCTICDB_USING_STATIC_XXHASH constant definitions and use CMake commands instead. #422

Closed
jjerphan opened this issue May 24, 2023 · 0 comments

Comments

@jjerphan
Copy link
Collaborator

jjerphan commented May 24, 2023

The ARCTICDB_USING_CONDA constant definitions has been introduced to build-specific configurations for conda-forge. It is currently necessary to handle some vendored dependencies using submodules (such as lmdb and lmdbxx which we do not want to maintain forks of) by modifying includes paths.

Moreover, the ARCTICDB_USING_STATIC_XXHASH is also used to be able to compile xxhash via its distributions on conda-forge.

Using logic based on constant definitions to adapt build-specific configuration is bad practice. Hence, we must adapt the build configuration to use CMake commands instead and remove the logic using ARCTICDB_USING_CONDA and ARCTICDB_USING_STATIC_XXHASH in the C++ headers. This might involve stopping using submodules and contributing to some dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants