Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

still using old retirement calls in the following files #1358

Closed
d-m-u opened this issue Feb 26, 2020 · 8 comments
Closed

still using old retirement calls in the following files #1358

d-m-u opened this issue Feb 26, 2020 · 8 comments
Labels

Comments

@d-m-u
Copy link
Contributor

d-m-u commented Feb 26, 2020

As of when this was opened, I think we're using the wrong call in at least the following places still:
I'll fix them as time allows. It's worth noting these changes should all go back to h and i.

https://github.com/ManageIQ/manageiq_docs/blob/39503bb22c58e413b42da6c056167c2166cd389b/api/reference/service_custom_actions.adoc#L338

https://github.com/ManageIQ/manageiq_docs/blob/abdf3b617f9f1233f76dfd877271cb71052aa001/api/overview/json.adoc#L250

https://github.com/ManageIQ/manageiq_docs/blob/ca32417489b7aa768e73cdeeb79b41d1548a6ddb/api/reference/services.adoc#L666

@chessbyte chessbyte added the bug label Apr 7, 2020
@chessbyte
Copy link
Member

@d-m-u what should those be changed to?

@d-m-u
Copy link
Contributor Author

d-m-u commented Apr 8, 2020

The updated API endpoint as of the last three versions is request_retire, not retire, getting to it today.

@d-m-u
Copy link
Contributor Author

d-m-u commented Apr 8, 2020

#1406
#1405

@chessbyte
Copy link
Member

@d-m-u @abellotti Now that #1405 and #1406 have been merged, can this issue be closed?

@abellotti
Copy link
Member

I still see one in api/examples/custom_action_service.adoc, I'll take care of it.

@abellotti
Copy link
Member

#1410

@chessbyte
Copy link
Member

@abellotti Now that #1405, #1406 and #1410 have been merged, can this issue be closed?

@abellotti
Copy link
Member

Yep 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants