Skip to content
This repository has been archived by the owner on Oct 6, 2021. It is now read-only.

Floyd Algorithm and Insertion sort bug fix #105

Merged
merged 5 commits into from Oct 1, 2021

Conversation

ishika22
Copy link
Contributor

@ishika22 ishika22 commented Oct 1, 2021

Have you read the Contribution Guidelines?

Yes

Checklist

  • [yes ] I've read the contribution guidelines.
  • [ yes] I've checked the issue list before deciding what to submit.
  • [ yes] I've edited the README.md and link to my code.

Related Issues (Mention Issue no. like #xxx)

Fixes Issue


Found an issue in insertion sort. Fixed it.

@ishika22 ishika22 mentioned this pull request Oct 1, 2021
@ishika22 ishika22 changed the title InsertionSort bug in Java Floyd Algorithm and Insertion sort bug fix Oct 1, 2021
@ishika22 ishika22 closed this Oct 1, 2021
@manan025
Copy link
Owner

manan025 commented Oct 1, 2021

@ishika22 any issues?

@ishika22
Copy link
Contributor Author

ishika22 commented Oct 1, 2021

@ishika22 any issues?

Hi @manan025
I found an issue in the InsertionSort file(the package name is incorrect and className is correct because of which we are getting alerts while running). By mistake, I created a PR for the fix as well without raising an issue. Hence closed it. Let me know if this can be taken up. I will reopen the PR.

@manan025
Copy link
Owner

manan025 commented Oct 1, 2021

No issues, I'll open and accept the PR.

@manan025 manan025 reopened this Oct 1, 2021
@manan025 manan025 merged commit ae210f1 into manan025:main Oct 1, 2021
@manan025 manan025 added the enhancement New feature or request label Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants