Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Inifinite overwrite when photos has same names #98

Closed
tymmej opened this issue Nov 14, 2022 · 0 comments · Fixed by #108
Closed

[BUG] Inifinite overwrite when photos has same names #98

tymmej opened this issue Nov 14, 2022 · 0 comments · Fixed by #108
Assignees
@mandarons
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
1.10.0

Comments

@tymmej
Copy link
Contributor

tymmej commented Nov 14, 2022

Describe the bug
Photo Library can contain multiple photos with same @Property filename.
Eg. default names IMG_xyza.HEIC when using multiple phones.

To Reproduce
Add photos with same names to library and run docker image.
You will see three things:

  1. number of downloaded files is different than in iCloud
  2. docker constantly downloads same files
  3. number of downloaded files is constant

Expected behavior
Docker downloads different files even if filenames are same. It should use @Property id to differentiate photos.

Screenshots
Screenshot_20221114_111059
Configuration
Backup all photos

Additional context
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mandarons mandarons

Labels
bug Something isn't working good first issue Good for newcomers
Projects
Backlog
Status: ✅ Done
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

Added photo quality and unique id to local photo names mandarons/icloud-drive-docker
2 participants
@tymmej @mandarons