New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests (and refactor) API extraction and symbol generation #1899

Open

mr-tz opened this issue Dec 9, 2023 · 0 comments

Labels

good first issue

Collaborator

mr-tz commented Dec 9, 2023

the routine you're updating is starting to look a little complicated, so maybe soon it's time to attempt to refactor, but without tests, i wouldn't be comfortable. even one trivial test would encode the special case/scenario that you encountered.

Originally posted by @williballenthin in #1897 (comment)

We should have more tests to encode all the various API patterns we support.

Refactoring of the existing routines and maybe introducing separate functions for .NET vs. native vs. others may make sense as part of that.

mike-hunhoff mentioned this issue

fix: do not trim api names that include :: #1897

Merged

3 tasks

mr-tz added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment