Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check types used to parse CIL operands #19

Closed
mike-hunhoff opened this issue Jun 30, 2022 · 2 comments
Closed

check types used to parse CIL operands #19

mike-hunhoff opened this issue Jun 30, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mike-hunhoff
Copy link
Collaborator

ensure signed/unsigned values used as defined by the spec.

see https://en.wikipedia.org/wiki/List_of_CIL_instructions.

see #18 (comment).

@mike-hunhoff mike-hunhoff added the enhancement New feature or request label Jun 30, 2022
@mike-hunhoff mike-hunhoff added this to the v1.0.1 milestone Jun 30, 2022
@mike-hunhoff mike-hunhoff self-assigned this Jul 12, 2022
@mike-hunhoff
Copy link
Collaborator Author

mike-hunhoff commented Jul 13, 2022

checked:

  • inline branch
  • inline field
  • inline_i
  • inline_i8
  • inline_method
  • inline_none
  • inline_phi
  • inline_r
  • inline_sig
  • inline_string
  • inline_switch
  • inline_tok
  • inline_type
  • inline_var
  • short_inline_br_target
  • short_inline_i
  • short_inline_r
  • short_inline_var
  • read_opcode
  • parse_header
  • parse_exception_handlers
  • parse_fat_exception_handlers
  • parse_tiny_exception_handlers

to update:

  • ldc.i4
  • ldc.i8
  • ldc.i4.s

@mike-hunhoff
Copy link
Collaborator Author

double-checked and fixed reader types - I could not find explicit definitions for the types used to parse exception handler data. assuming unsigned works for these - we can reopen in the future if we encounter any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant