Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate PieceDownload's received block without unwraps #16

Closed
vimpunk opened this issue Mar 30, 2020 · 1 comment
Closed

Validate PieceDownload's received block without unwraps #16

vimpunk opened this issue Mar 30, 2020 · 1 comment

Comments

@vimpunk
Copy link
Owner

vimpunk commented Mar 30, 2020

No description provided.

@vimpunk
Copy link
Owner Author

vimpunk commented Dec 21, 2020

This is actually fine since it's a protocol impl bug if blocks aren't verified (which now they are). If any invalid blocks still get to the download (or other internal layers), it's an application bug that should cause the program to panic.

@vimpunk vimpunk closed this as completed Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vimpunk