Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comparison between signed and unsigned integer #38

Merged
merged 2 commits into from Feb 2, 2019

Conversation

amallia
Copy link
Contributor

@amallia amallia commented Jan 30, 2019

mio/include/mio/detail/mmap.ipp:327:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     if(offset + length > file_size)
        ~~~~~~~~~~~~~~~~^~~~~~~~~~~

@vimpunk
Copy link
Owner

vimpunk commented Feb 2, 2019

Thanks for this! I'd rather that query_file_size's return value be size_t. Could you quickly change it to that?

@amallia
Copy link
Contributor Author

amallia commented Feb 2, 2019

Thanks for this! I'd rather that query_file_size's return value be size_t. Could you quickly change it to that?

Sure. Done!

@vimpunk
Copy link
Owner

vimpunk commented Feb 2, 2019

Fantastic, thanks! :)

@vimpunk vimpunk merged commit 3c658bf into vimpunk:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants