fix: detect Node.js runtime

Azure · Sep 14, 2020 · bcda33c · bcda33c
1 parent f9c6c18
commit bcda33c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/bin/index.js b/bin/index.js
@@ -84,8 +84,6 @@ const startCommand = [
   `"(cd ./src/auth/; func start --cors=* --port=${authUriPort})"`,
 
   // serve the app
-  // See available options for http-server: https://github.com/http-party/http-server#available-options
-  // Note: --proxy allows us to add fallback routes for SPA (https://github.com/http-party/http-server#catch-all-redirect)
   `"${hostCommand} ${hostArgs.join(" ")}"`,
 
   // serve the api, if it's available

diff --git a/src/runtimeHost.js b/src/runtimeHost.js
@@ -3,6 +3,7 @@ const { readConfigFile } = require("./utils");
 const { detectRuntime, RuntimeType } = require("./runtimes");
 
 const httpServerBin = path.resolve(__dirname, "..", "./node_modules/.bin/http-server");
+
 module.exports.createRuntimeHost = (port, proxyHost, proxyPort) => {
   const { app_location, app_artifact_location } = readConfigFile();
   const runtimeType = detectRuntime(app_location);
@@ -16,6 +17,8 @@ module.exports.createRuntimeHost = (port, proxyHost, proxyPort) => {
 
     case RuntimeType.node:
     default:
+      // See available options for http-server: https://github.com/http-party/http-server#available-options
+      // Note: --proxy allows us to add fallback routes for SPA (https://github.com/http-party/http-server#catch-all-redirect)
       const command = httpServerBin;
       const args = `${app_artifact_location} -p ${port} -c-1 --proxy http://${proxyHost}:${proxyPort}/?`.split(" ");
 

diff --git a/src/runtimes.js b/src/runtimes.js
@@ -16,7 +16,7 @@ module.exports.detectRuntime = (app_location) => {
     return RuntimeType.dotnet;
   }
 
-  if (files.some((file) => path.extname(file) === "package.json")) {
+  if (files.includes("package.json")) {
     return RuntimeType.node;
   }