Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product impl always return 0 #39

Closed
ManevilleF opened this issue Feb 14, 2023 · 0 comments · Fixed by #38
Closed

Product impl always return 0 #39

ManevilleF opened this issue Feb 14, 2023 · 0 comments · Fixed by #38
Labels
bug Something isn't working
Milestone
0.4.1

Comments

@ManevilleF
Copy link
Owner

If we have an iterator of Hex called hex_iter then:

hex_iter.product()

will always return Hex::ZERO
@ManevilleF ManevilleF added the bug Something isn't working label Feb 14, 2023
@ManevilleF ManevilleF changed the title Product implemetation always return 0 Product impl always return 0 Feb 14, 2023
@ManevilleF ManevilleF added this to the 0.4.1 milestone Feb 14, 2023
@ManevilleF ManevilleF mentioned this issue Feb 14, 2023
Merged
ManevilleF added a commit that referenced this issue Feb 15, 2023
@ManevilleF
Feat/extra operations (#38)
93fd412 
> Closes #39 

## Fix

* Fixed `Product` impl for `Hex` which is always returning (0, 0) #39 

## Additions

* Added `Hex::min` method
* Added `Hex::max` method
* Added `Hex::signum` method
* Added `Hex::dot` method
* Added `Hex::from_slice` method
* Added `Hex::write_to_slice` method
* Added `Hex::dot` method

## Impls

* Added `BitOr` implementations for `Hex`
* Added `BitXor` implementations for `Hex`
* Added `BitAnd` implementations for `Hex`
* Added `Shr` implementations for `Hex`
* Added `Shl` implementations for `Hex`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.4.1
Development

Successfully merging a pull request may close this issue.

Feat/extra operations ManevilleF/hexx
1 participant
@ManevilleF