Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PartialEq for HexDirection #83

Closed
GuimilXD opened this issue May 9, 2023 · 2 comments · Fixed by #87
Closed

Implement PartialEq for HexDirection #83

GuimilXD opened this issue May 9, 2023 · 2 comments · Fixed by #87
Labels
good first issue Good for newcomers usability Make the APIs easier to use
Milestone
0.7.0

Comments

@GuimilXD
Copy link
Contributor

GuimilXD commented May 9, 2023 •
edited

Is your feature request related to a problem? Please describe.
I'd like to create an egui slider that controls the HexOrientation of a hex map.

Describe the solution you'd like
I'd like to HexOrientation to implement PartialEq and possibly other common traits.

Describe alternatives you've considered
I've created an enum that implemented Into<HexOrientation>, but found the bodge to be just ugly.

Additional context
image
@alice-i-cecile alice-i-cecile added the usability Make the APIs easier to use label May 9, 2023
@ManevilleF ManevilleF added the good first issue Good for newcomers label May 9, 2023
@GuimilXD
Copy link
Contributor Author

GuimilXD commented May 9, 2023

So, is it ok if I pull request a quick fix? I just need it to be working ASAP. In the future I might even try to implement the enum version and PR that.

@alice-i-cecile
Copy link
Collaborator

Yes, please feel free!

@GuimilXD GuimilXD mentioned this issue May 9, 2023
Merged
ManevilleF pushed a commit that referenced this issue May 22, 2023
@GuimilXD
Implement PartialEq for HexOrientation (#87)
29a96c5 
Fixes: #83
@ManevilleF ManevilleF added this to the 0.7.0 milestone Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers usability Make the APIs easier to use
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Implement PartialEq for HexOrientation GuimilXD/hexx
3 participants
@alice-i-cecile @ManevilleF @GuimilXD