Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fast-sha256 dependency #1250

Closed
maksimvoevodskij81 opened this issue Aug 11, 2022 · 1 comment
Closed

Update fast-sha256 dependency #1250

maksimvoevodskij81 opened this issue Aug 11, 2022 · 1 comment
Labels
bug For tagging faulty or unexpected behavior. investigation-needed Indication that the maintainer or involved community members may need to investigate more.

Comments

@maksimvoevodskij81
Copy link

Is your feature request related to a problem? Please describe.
When building Angular 14 application with reference to angular-oauth2-oidc, the following warning occurs:

\node_modules\angular-oauth2-oidc\fesm2015\angular-oauth2-oidc.mjs depends on 'fast-sha256'. CommonJS or AMD dependencies can cause optimization bailouts.

fast-sha256 dependency is a CommonJS library which prevents bundlers and minifiers from optimizing an application (according to Angular official doc)

Describe the solution you'd like
Replace fast-sha256 library with any other suitable counterpart which is built using ECMAScript modules feature.
@jeroenheijmans jeroenheijmans added bug For tagging faulty or unexpected behavior. investigation-needed Indication that the maintainer or involved community members may need to investigate more. labels Oct 2, 2022
@manfredsteyer
Copy link
Owner

Will be resolved in next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug For tagging faulty or unexpected behavior. investigation-needed Indication that the maintainer or involved community members may need to investigate more.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@manfredsteyer @jeroenheijmans @maksimvoevodskij81