Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks build when using jest #59

Closed
Twista opened this issue Jan 10, 2019 · 1 comment
Closed

Breaks build when using jest #59

Twista opened this issue Jan 10, 2019 · 1 comment

Comments

@Twista
Copy link

Twista commented Jan 10, 2019

Hello, I just tried to use the library, unfortunately, it's breaking build because of jasmine (we are using jest for testing)

version: ngx-build-modern@1.1.3

running regular (old) build (ng build --prod --configuration=production)
1____w_a_c_dashboard__fish_

running modern build (yarn run build:modern)
1____w_a_c_dashboard__node_

When removed jasmine (diry rm -rf jasmine @types/jasmine) build was succesfull (with both cases).

only library (based on yarn list) which brings jasmine into the project is this one. Do you think it will be solvable? (e.g move jasmine to devDependencies).

Also, let me know if any other information is needed, will be glad to help :)

@manfredsteyer
Copy link
Owner

Thanks for pointing this out. The lib has not been tested with jest and the test builder is delegating to the CLI's karma-builder. Feel free to add a PR for supporting jest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants