Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100% zoom on the reader should be possible #1859

Open
Tracked by #40
Robonau opened this issue Jun 7, 2020 · 9 comments
Open
Tracked by #40

100% zoom on the reader should be possible #1859

Robonau opened this issue Jun 7, 2020 · 9 comments
Assignees
Labels
Enhancement Improvement or Feature

Comments

@Robonau
Copy link
Contributor

Robonau commented Jun 7, 2020

mostly for people that read with a portrait monitor but as it is it starts at 75% and goes up in 15% intervals meaning 75,90,105 100% is impossible. having it edge to edge without missing out on text in bubbles would be really nice, changing it to start at 70 or making the interval 12.5 would both be functional fixes (i got the zoom numbers by pressing f12 and looking around a bit)

@Robonau
Copy link
Contributor Author

Robonau commented Jun 7, 2020

note: i managed to do this personally but am too dumb to actually use GitHub, and am also too dumb to actually make it build it is am currently just running it using a bat file that does npm start, i did this a while ago and do not remember what i changed

@Robonau
Copy link
Contributor Author

Robonau commented Jun 7, 2020

i think i found the change (not totally sure)(it's a change in the theme so all themes would have to be changed not just dark)
hakuneko-master\src\web\lib\hakuneko\frontend@classic-dark\pages.html
line 192
this.imageWidth = 75;
to
this.imageWidth = 100;

@Sheepux
Copy link
Contributor

Sheepux commented Jun 7, 2020

So, on your third post : what you're asking is an option to get images "fit to browser width" when opening the viewer.
I've done some testing and it could be an option but not something done by default as most users are on 16/10 screens : full width zoom is too much (i guess Ronny did some testing and found out that 75 is good enougth).
I personnaly prefer the current zoom at 75.

What could be done:

  • Shortcut "*" means full screen width zoom
  • Shortcut "/" is default zoom
  • Using "+ or -" should round to 100 (when going from 90 to 105)
  • Option in the config menu to be able to configure the default zoom (currently 75)
  • Option to configure this per manga (and remember it), probably on the top right toolbar when the viewer is open.

@Sheepux Sheepux added the Enhancement Improvement or Feature label Jun 7, 2020
@Robonau
Copy link
Contributor Author

Robonau commented Jun 7, 2020

the third post is just how i did it for myself just cause it was the quick and dirty option to get what i wanted
i get that if you are reading in 16/9 that 75 would be nicer than 100 (i did that before swapping to portrait)
i think the last two options would be best case cause it would allow you to set any amount of zoom (as an integer) though i imagine the last option to be the hardest/most annoying to implement. the last is also probably unnecessary, i would guess most ppl read all there manga at the same zoom.

@Sheepux
Copy link
Contributor

Sheepux commented Jun 8, 2020

Option 6 "auto mode" : figure out what's the current screen ratio and set up the default zoom accordingly (only on first launch ? Everytime the app is started ? Every time the viewer is started ?)

@Robonau
Copy link
Contributor Author

Robonau commented Jun 9, 2020

it'd only be useful for me if it were done when the reader was started, i swap between landscape and portrait for things other than reading.(i only read in portrait tho so wouldn't really be useful)
being able to manually enter a zoom value is most important tho.
would it not be allot easier to have hotkeys to zoom profiles (idk i don't code much) i imagine detecting screen rotation would be a bit of a pain

@Sheepux
Copy link
Contributor

Sheepux commented Jun 9, 2020

Detecting rotation is not an issue as we can be notified of such event (available in electron and NWjs)
https://www.electronjs.org/docs/api/screen (event display-metrics-changed )
https://docs.nwjs.io/en/latest/References/Screen/ (event Event: displayBoundsChanged(screen) )

If i understand well your last statement, you'd like to set yourself the different values and the +/- actions would simply swap between those
Something like:

  • Profile 1
    • Portrait 50
    • Landscape 60
  • Profile 2
    • Portrait 60
    • Landscape 75
  • Profile 3
    • Portrait 75
    • Landscape 100
  • Profile 4
    • Portrait 90
    • Landscape 120
  • Profile 4
    • Portrait 100
    • Landscape 140

Default Profile: 3

Outbound increment:

  • Portrait 15
  • Landscape 10

And in the top right menu the ability to select those value (not presenting "profile x" but it's value and the possibility to change it manually.
Possibly also "fit to width" & "fit to heigth"

@Sheepux Sheepux self-assigned this Jun 9, 2020
@Robonau
Copy link
Contributor Author

Robonau commented Jun 10, 2020

something like that would be pretty much ideal yea.

@Sheepux
Copy link
Contributor

Sheepux commented Jun 14, 2020

Just commited the zoom 100% on shorcut * within an other request. Just wait for the merge.
I'll let this issue open as there are a few ideas that could be interresting to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement or Feature
Projects
None yet
Development

No branches or pull requests

2 participants