Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Alternative titles #2830

Closed
MarqFJA87 opened this issue Dec 28, 2020 · 6 comments
Closed

[Feature] Alternative titles #2830

MarqFJA87 opened this issue Dec 28, 2020 · 6 comments
Labels
Enhancement Improvement or Feature Won't Fix

Comments

@MarqFJA87
Copy link

MarqFJA87 commented Dec 28, 2020

I've been reorganizing some of my folders now that I've replaced one of my almost full external hard drives with a much bigger one; this reorganization included moving both the HakuNeko manga directory and my main directory for all things manga to the new drive, now that I have enough space for both. Unfortunately, this ran into a serious problem: several of the downloaded manga have such long titles that they exceed the 256 character limit on folder/file paths, forcing me to repeatedly move the HakuNeko directory one level at a time, until I finally managed to stay within the limit by putting at the very top level (i.e. it's now "G:\HakuNeko"). Most of the problematic manga only required a single level rise to fix the problem, but one manga had an especially long title that forced the repeated moves: Even Though I'm a Former Noble and a Single Mother, My Daughters Are Too Cute and Working as an Adventurer Isn’t Too Much of a Hassle, commonly shortened to MotoMusu. And yes, there are other manga with similarly super-long titles; I can dig them up if so desired.

The solution to the problem IMO seems fairly simple: have HakuNeko be able to detect the existence of alternative titles, and allow the user to pick one of them to use instead of the main title. An alternative solution would be to allow the user to change a bookmarked manga's title. HakuNeko already has a similar phenomenon where even when a manga's title on a site is changed, HakuNeko still retains the old title in its database and continues to operate as normal; it's only if the user for some reason unbookmarks and then rebookmarks the manga in question that the title is changed, and that the old folder has to be renamed accordingly in order for HakuNeko to detect any previously downloaded chapters.

My current HakuNeko Version is 6.17. The OS is Windows 10.

@MarqFJA87 MarqFJA87 added the Enhancement Improvement or Feature label Dec 28, 2020
@Sheepux
Copy link
Contributor

Sheepux commented Dec 28, 2020

Something like right click > custom name > text input

@Robonau
Copy link
Contributor

Robonau commented Jan 3, 2021

suggested alt names might be a good idea (mangaupdates would probably be the best source of alt names)

@MarqFJA87
Copy link
Author

suggested alt names might be a good idea (mangaupdates would probably be the best source of alt names)

MangaDex commonly provides alternative titles as well, though not everybody can add them. AFAIK only the staff, uploaders, and those with the "contributor" role could do it.

@ronny1982
Copy link
Contributor

ronny1982 commented Jan 3, 2021

HakuNeko is folder/file based, it cannot remember when a user select a different name for a manga and therefore it will not appear in the list anymore, the original being seen as not downloaded.

A fix can be added to the sanitize method, but i think this is a problem with windows itself and there is a registry hack to enable unlimited path length support

// TODO: max. 260 characters per path

@MarqFJA87
Copy link
Author

MarqFJA87 commented Jan 3, 2021

HakuNeko is folder/file based, it cannot remember when a user select a different name for a manga and therefore it will not appear in the list anymore, the original being seen as not downloaded.

You mean if a manga's title was changed on MangaDex after I downloaded chapters from it, and then I checked MangaDex's list on HakuNeko, I'd see the new title and the old one as separate entries? Yet HakuNeko clearly uses the base URL (i.e. without tacking on the title, as MD links often get formatted), because even after a title change it can detect additions, removals and renamings of the manga's chapters.

A fix can be added to the sanitize method, but i think this is a problem with windows itself and there is a registry hack to enable unlimited path length support

// TODO: max. 260 characters per path

What does this fix do, exactly? I don't mean in technical terms, just so we're clear.

@ronny1982
Copy link
Contributor

Requires to much effort => rejected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement or Feature Won't Fix
Projects
None yet
Development

No branches or pull requests

4 participants