Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card Registration Kit in the gem #31

Closed
tildedash opened this issue Sep 24, 2015 · 2 comments
Closed

Card Registration Kit in the gem #31

tildedash opened this issue Sep 24, 2015 · 2 comments

Comments

@tildedash
Copy link

Hello,

I am testing your solution in a RoR project and I wonder why you did not include the card registration JS kit (at least the minified one) in the gem.

I had to host it myself in the RoR project so if the JS kit has any changes, I will still get an obsolete one in my project.

Another solution is to wrap the JS kit in another gem (like backbone : https://github.com/codebrew/backbone-rails ).

Finally, providing a minified version hosted by Mangopay itself (like Stripe do: https://js.stripe.com/v2/) is a good solution too.

Regards

@javiercr
Copy link

javiercr commented Oct 6, 2015

The Card Registration Kit is distributed as a bower package.

Therefore one option to achieve what you want would be to use bower-rails in your Rails project and add the Card Registration Kit as a bower dependency.

In Rails projects I usually store the card-registration-kit in /vendor/assets/javascript. I am not changing the implementation of the payment processing that often to need bower or a gem.

Hope it helps.

@hobailey
Copy link
Contributor

Hi @tildedash, thanks for this feedback and I'm sorry for the delay getting back to you. I totally agree with @javiercr - a bower package would be the best forward for the moment :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants