Eliminate race condition in World Log.

In has been introduced with multithreaded packet processing, and prevents the dump from being written correctly, e.g. with tools.
mangos · Aug 1, 2012 · 18e130e · 18e130e
1 parent 19c201e
commit 18e130e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/shared/Log.cpp b/src/shared/Log.cpp
@@ -714,6 +714,8 @@ void Log::outWorldPacketDump( uint32 socket, uint32 opcode, char const* opcodeNa
     if (!worldLogfile)
         return;
 
+    ACE_GUARD(ACE_Thread_Mutex, GuardObj, m_worldLogMtx);
+
     outTimestamp(worldLogfile);
 
     fprintf(worldLogfile,"\n%s:\nSOCKET: %u\nLENGTH: " SIZEFMTD "\nOPCODE: %s (0x%.4X)\nDATA:\n",

diff --git a/src/shared/Log.h b/src/shared/Log.h
@@ -167,6 +167,7 @@ class Log : public MaNGOS::Singleton<Log, MaNGOS::ClassLevelLockable<Log, ACE_Th
         FILE* charLogfile;
         FILE* dberLogfile;
         FILE* worldLogfile;
+        ACE_Thread_Mutex m_worldLogMtx;
 
         // log/console control
         LogLevel m_logLevel;