[10725] Add a few comments for SUMMON_PROP_TYPE_CRITTER

Signed-off-by: NoFantasy <nofantasy@nf.no>
mangos · Nov 15, 2010 · 49d5a51 · 49d5a51
1 parent 833d642
commit 49d5a51
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/src/game/DBCStructure.h b/src/game/DBCStructure.h
@@ -1632,7 +1632,7 @@ struct SummonPropertiesEntry
     uint32  Group;                                          // 1, enum SummonPropGroup
     uint32  FactionId;                                      // 2,                        14 rows > 0
     uint32  Type;                                           // 3, enum SummonPropType
-    uint32  Slot;                                           // 4,   if type = SUMMON_PROP_TYPE_TOTEM, its actual slot    0-6
+    uint32  Slot;                                           // 4, if type = SUMMON_PROP_TYPE_TOTEM, its actual slot (0-6). Slot may have other uses, selection of pet type in some cases?
     uint32  Flags;                                          // 5, enum SummonPropFlags
 };
 

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
@@ -4094,6 +4094,9 @@ void Spell::EffectSummonType(SpellEffectIndex eff_idx)
                     break;
                 case SUMMON_PROP_TYPE_CRITTER:
                     DoSummonCritter(eff_idx, summon_prop->FactionId);
+                    // TODO: differenciate between regular 'critter' types and 'critter' that are fighting.
+                    // prop_id == 387 are expected to be fighting (but they have postfix 'companion').
+                    // Note: summon_prop->Slot==6 may be related to how selection are done for this type (need more research)
                     break;
                 case SUMMON_PROP_TYPE_PHASING:
                 case SUMMON_PROP_TYPE_LIGHTWELL:

diff --git a/src/shared/revision_nr.h b/src/shared/revision_nr.h
@@ -1,4 +1,4 @@
 #ifndef __REVISION_NR_H__
 #define __REVISION_NR_H__
- #define REVISION_NR "10724"
+ #define REVISION_NR "10725"
 #endif // __REVISION_NR_H__