Skip to content

Commit

Permalink
[10895] Description for found gender field in CreatureDisplayInfoExtr…
Browse files Browse the repository at this point in the history
…aEntry.

Sign-off-by: VladimirMangos <vladimir@getmangos.com>
  • Loading branch information
Darkrulerz authored and VladimirMangos committed Dec 20, 2010
1 parent dad1f09 commit 53aa219
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/game/DBCStructure.h
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,7 @@ struct CreatureDisplayInfoExtraEntry
{
uint32 DisplayExtraId; // 0 CreatureDisplayInfoEntry::m_extendedDisplayInfoID
uint32 Race; // 1
// 2 unknown, 0/1
//uint32 Gender; // 2 Model gender, exist not small amount cases when query creature data return different gender from used model, so can't be replacement for model gender field.
// 3-7 unknown, 0..~2x
//uint32 Equipment[11] // 8-18 equipped static items EQUIPMENT_SLOT_HEAD..EQUIPMENT_SLOT_HANDS, client show its by self
// 19 unknown, 0/1
Expand Down
2 changes: 1 addition & 1 deletion src/shared/revision_nr.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__
#define __REVISION_NR_H__
#define REVISION_NR "10894"
#define REVISION_NR "10895"
#endif // __REVISION_NR_H__

2 comments on commit 53aa219

@Neo2003
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use dbc only data and drop the field in DB.
Use CreatureDisplayInfo : 1st column is modelid, 4th column is DisplayExtraID. If DisplayExtraID == 0 then gender = 2.
With this DisplayExtraID != 0, locate the record in CreatureDisplayInfoExtra, then gender is the 3rd column.

I use this way to get the gender for a very long time to fill the DB.

@VladimirMangos
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't. In other commit discusstion i already write this: creature query gender often not match to gender in displayextra.
In proved correct query data from retial. before do commit i adding modeinfo loading compatibility checks and lost many time for compare result and look way resolve problems. No chance for replace. in checks i attempt implement exactly way:

Use CreatureDisplayInfo : 1st column is modelid, 4th column is DisplayExtraID. If DisplayExtraID == 0 then gender = 2.
With this DisplayExtraID != 0, locate the record in CreatureDisplayInfoExtra, then gender is the 3rd column.

Please sign in to comment.