-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[11136] Add Creature::FillGuidsListFromThreatList for safe guid itera…
…tion from threat list. Often not 100%-safe iterate by live threat list because called code can modify threat list (reset for example).
- Loading branch information
VladimirMangos
committed
Feb 11, 2011
1 parent
c71c4e5
commit 66d1972
Showing
3 changed files
with
19 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#ifndef __REVISION_NR_H__ | ||
#define __REVISION_NR_H__ | ||
#define REVISION_NR "11135" | ||
#define REVISION_NR "11136" | ||
#endif // __REVISION_NR_H__ |
66d1972
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long live the thread-safe code!
:)
66d1972
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in fact it can fail and in single thread
66d1972
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also in mangos this code mostly for scripts that executed for single map objects so not expected any other thread affects base at planned thread usage way.
66d1972
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may offer this:
https://github.com/rsa/mangos/commit/fdf656d23a114f5dd3fd17ec77b7ae766bade4a2
not need with current mangos code, but required for thread-safe. tested, worked fine.