Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[11062] Correctly show team member status while teleporting
- Loading branch information
cyberium
authored and
Ambal
committed
Jan 21, 2011
1 parent
f0475c8
commit b447452
Showing
2 changed files
with
29 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#ifndef __REVISION_NR_H__ | ||
#define __REVISION_NR_H__ | ||
#define REVISION_NR "11061" | ||
#define REVISION_NR "11062" | ||
#endif // __REVISION_NR_H__ |
b447452
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zone cached in Player field. Ofc it can be not exatly same for in world state to current pos but for non in world state it useful.
I recently use it for another packet.
b447452
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Vladimir. Thanks for comment. 'Unknown' player status case shouldn't appear at all: if player is not in world and is not being teleported then what is his status?
b447452
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then why else part ;)
b447452
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to place MANGOS_ASSERT() there to crash some servers and find out how we can get in this case :D
b447452
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in fact i also think good place assert in like case
b447452
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tryed with one of my "BOOM!!!" code but i can confirm never seen it active in last "else".
Place assert will definitivly help us to see if another player status is possible.
If no feedback about this we simply can assume 'if not in world then is being teleported'
b447452
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should definitely add some checks to prevent wrong code use in the future.