-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[11986] Improve targeting for spells with TARGET_TOTEM_* targets
- Loading branch information
1 parent
62a00dc
commit b6db6c7
Showing
2 changed files
with
22 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#ifndef __REVISION_NR_H__ | ||
#define __REVISION_NR_H__ | ||
#define REVISION_NR "11985" | ||
#define REVISION_NR "11986" | ||
#endif // __REVISION_NR_H__ |
b6db6c7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
author MaxXx2021 (Mioka) if remember correctly. method not fully good, and have some problems - at least possibility summon behind the wal...
b6db6c7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am aware that the position might be behind a wall.
But such a corner case will require some more research (change angle/ change distante?).
Sure it is possible that Mioka wrote a similar patch ago. But I am not aware of this (and as mangos forum is down I could not go on search for such patches)
b6db6c7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, old code where totem created auto select proper point nearest to expected, including LoS check.
b6db6c7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I will share some retail research about this. When a totem (or any other summon, for the record) would be summoned in an invalid position (such as out of LoS) the position is instead moved directly on top of caster.
b6db6c7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you shauren :)
Question about this: Is only the summon position a valid position, or already the position that the spell targets?
b6db6c7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have to do testing what is sent in SMSG_SPELL_GO, will do some time soon.
b6db6c7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, here it is http://pastebin.com/ZLeTtzsf
As you can see in sniff, the spell target destination is also set to caster's position (this is only case when dest = caster, no normal case in there)