Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit of printed positions is hard-coded to the default value #130

Closed
fabian-s opened this issue Aug 18, 2019 · 1 comment · Fixed by #131
Closed

limit of printed positions is hard-coded to the default value #130

fabian-s opened this issue Aug 18, 2019 · 1 comment · Fixed by #131
Projects
Development
Milestone
v1.0.3

Comments

@fabian-s
Copy link
Contributor

fabian-s commented Aug 18, 2019 •
edited

goodpractice/R/print.R

Line 127 in f315d32

if (length(pos) > limit) pos <- pos[1:5]

should be pos[1:limit]

EDIT:

goodpractice/R/print.R

Line 137 in f315d32

and <- paste0(" ... and ", num - 5, " more lines\n")

same here
@gaborcsardi
Copy link
Collaborator

Right. Would you like to submit a pull request?

@fabian-s fabian-s mentioned this issue Aug 19, 2019
Merged
@owenjonesuob owenjonesuob added this to open in Development Jun 28, 2021
@owenjonesuob owenjonesuob added this to the v1.0.3 milestone Jul 6, 2021
@owenjonesuob owenjonesuob moved this from open to todo in Development Jul 6, 2021
@owenjonesuob owenjonesuob moved this from todo to done in Development Jul 6, 2021
owenjonesuob added a commit that referenced this issue Jul 8, 2021
@owenjonesuob
Add entry for #130 to NEWS.md
b6cb312
@owenjonesuob owenjonesuob mentioned this issue Jul 12, 2021
Merged
4 tasks
Development automation moved this from done to closed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Development
closed
Milestone
v1.0.3
Development

Successfully merging a pull request may close this issue.

lets print.gp control how many positions are shown
3 participants
@gaborcsardi @fabian-s @owenjonesuob