Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner bot, cannot clean offer made by failing offer bot #13

Open
peterMangrove opened this issue Feb 20, 2023 · 1 comment
Open

Cleaner bot, cannot clean offer made by failing offer bot #13

peterMangrove opened this issue Feb 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@peterMangrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The failing offer bot post offers, but does not have the funds for the actual offers when they get matched.
The cleaning bot tries to snipe offers, by taking 0% of the offer. But this does not trigger a makerTransferFail, because transferring 0 amount of tokens is okay.

Describe the solution you'd like
The cleaner bot should be able to clean offers, where the maker does not have the funds. This can be done by either giving the cleaning offer bot owner address, a small amount of different tokens or using a "whale" (another address, that has a lot of tokens) and then trying to snipe on behalf that address. MgvCleaner has the functionality called collectByImpersonation. This would require that whale to approve MgvCleaner to use it tokens. Since MgvCleaner can never successfully snipe any offers, this would not be dangerous for the whale.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@peterMangrove peterMangrove added the enhancement New feature or request label Feb 20, 2023
@espendk espendk transferred this issue from mangrovedao/mangrove.js May 26, 2023
@lnist
Copy link
Contributor

lnist commented Jan 10, 2024

@Louis-Amas is this fixed? (The failing offer bot does not exist anymore, but the issue of what cleaning bot could not clean)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants