Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AwssumePlugin - support more situations #110

Closed
kmanning opened this issue Sep 3, 2019 · 3 comments
Closed

AwssumePlugin - support more situations #110

kmanning opened this issue Sep 3, 2019 · 3 comments

Comments

@kmanning
Copy link
Collaborator

kmanning commented Sep 3, 2019

  • Support both upper and lower case environment variable names for role ARN's
  • First look for 'AWS_ROLE_ARN', then look for environment-specific. Hierarchy:
    • Allow parameters to take highest precedence. If I want to override any defaults, I should be able to set AWS_ROLE_ARN directly for an environment.
    • Allow environment-specific roles to take second precendence, as a means to manage lots of pipelines across a team.
  • If nothing is found, just skip AwssumePlugin all together
  • Also, fix AWS_DEFAULT_REGION
@kmanning
Copy link
Collaborator Author

kmanning commented Sep 3, 2019

I like the sound of this functionality. It seems to me like it would handle most common use cases, including the many teams that use some form of <environment>_AWS_ROLE_ARN as well as a lot of RE's infrastructure/utility jobs that are account-specific repos/pipelines and have an ARN hard-coded.

@kmanning
Copy link
Collaborator Author

kmanning commented Sep 3, 2019

Defect: There's fishy behavior with the AWS_REGION variable here. I know I've seen it fail in the past. Vipar has AWS_DEFAULT_REGION set, and awssume documentation only talks about AWS_DEFAULT_REGION.

https://github.com/manheim/awssume

@kmanning
Copy link
Collaborator Author

kmanning commented Sep 3, 2019

Creating separate issue - investigate behavior further there. Issue #130

@kmanning kmanning closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant