Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defect: CrqPlugin skips apply - v4.1, v4.2, v4.3 #143

Closed
kmanning opened this issue Sep 3, 2019 · 0 comments
Closed

Defect: CrqPlugin skips apply - v4.1, v4.2, v4.3 #143

kmanning opened this issue Sep 3, 2019 · 0 comments

Comments

@kmanning
Copy link
Collaborator

kmanning commented Sep 3, 2019

  • Enable the CRQPlugin
  • Run trigger a plan/apply for an environment that does not have a CRQ_ENVIRONMENT set
  • Expected: The apply should still run, but without CRQOpen and CRQClose
  • Actual: The apply is skipped

There is a defect in the refactor that happened to the CrqPlugin in v4.1. In the else clause, the closure should be executed. it is not, hence the rest of the pipeline is skipped.

./src/CrqPlugin.groovy#L35-L52

@kmanning kmanning closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant