Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CPS mismatch errors, reduce meta magic in Jenkinsfile.groovy and Stage decorations #151

Closed
kmanning opened this issue Sep 3, 2019 · 1 comment · Fixed by #202
Closed

Fix CPS mismatch errors, reduce meta magic in Jenkinsfile.groovy and Stage decorations #151

kmanning opened this issue Sep 3, 2019 · 1 comment · Fixed by #202
Labels
enhancement New feature or request
Milestone
v5.5

Comments

@kmanning
Copy link
Collaborator

kmanning commented Sep 3, 2019 •
edited
Loading

  • Jenkinsfile is doing a lot of weird meta-magic. In hindsight, none of this should be necessary.
  • Create a function in the ./vars folder, and execute the Jenkinsfile closures there. That should give us a reference to all the Jenkinsfile DSL methods, and remove the need to do the meta-magic in Jenkinsfile.
  • Some versions of the pipeline plugin are showing CPS mismatch errors. Eg: expected to call DefaultEnvironmentPlugin.withEnv but wound up catching Jenkinsfile.invokeMethod; see: https://jenkins.io/redirect/pipeline-cps-method-mismatches/ [Pipeline] withEnv. Fix the CPS errors as part of this cleanup.
@kmanning kmanning added this to the v5.1 milestone Sep 3, 2019
@kmanning kmanning modified the milestones: v5.1, v5.2 Oct 1, 2019
@kmanning kmanning modified the milestones: v5.2, v5.3 Oct 30, 2019
@kmanning kmanning removed this from the v5.3 milestone Jan 14, 2020
@kmanning kmanning added the enhancement New feature or request label Jan 15, 2020
@kmanning kmanning added this to the v5.5 milestone Mar 9, 2020
@kmanning kmanning changed the title Simplify Jenkinsfile Fix CPS mismatch errors, reduce meta magic in Jenkinsfile.groovy Mar 16, 2020
@kmanning kmanning changed the title Fix CPS mismatch errors, reduce meta magic in Jenkinsfile.groovy Fix CPS mismatch errors, reduce meta magic in Jenkinsfile.groovy and Stage decorations Mar 18, 2020
@kmanning kmanning mentioned this issue Mar 18, 2020
Closed
@kmanning kmanning linked a pull request Mar 18, 2020 that will close this issue
Issue 151 - Fix CPS mismatch errors, reduce meta magic in Jenkinsfile.groovy and Stage decorations #202
Merged
@kmanning
Copy link
Collaborator Author

kmanning commented Mar 18, 2020 •
edited
Loading

Merged into v5.5-dev

This was referenced Mar 18, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v5.5
1 participant
@kmanning