Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmApplyPlugin - allow message customization #24

Closed
kmanning opened this issue Sep 3, 2019 · 3 comments
Closed

ConfirmApplyPlugin - allow message customization #24

kmanning opened this issue Sep 3, 2019 · 3 comments
Milestone

Comments

@kmanning
Copy link
Collaborator

kmanning commented Sep 3, 2019

  • Allow it to be enabled/disabled
  • Allow the text of the prompts to be overridden

Example:

...
ConfirmApplyPlugin.disable()
...

The human confirmation step for every environment should now go straight from plan to apply, without prompting the user.

Do we care about skipping some environments and not others?

@kmanning
Copy link
Collaborator Author

kmanning commented Jul 20, 2020

Acceptance Criteria:

Given When Then
I override the confirm message my pipeline runs I see the new message asking me to confirm before applying the terraform plan
I override the Ok message my pipeline runs I see the new label on the OK button to confirm
I override the submitter my pipeline runs (where is this even used...?)

@kmanning
Copy link
Collaborator Author

The disable functionality seems potentially dangerous. Consider separating that into another issue. If we move forward with it, it should get a clear warning about what will happen.

@kmanning kmanning added this to the v5.9 milestone Jul 25, 2020
@kmanning kmanning changed the title ConfirmApplyPlugin - allow customization ConfirmApplyPlugin - allow message customization Jul 30, 2020
@kmanning
Copy link
Collaborator Author

Removing disable functionality, and pushing it to another Issue #264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant