Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Upgrade to Junit 5 #332

Closed
kmanning opened this issue Feb 2, 2021 · 0 comments · Fixed by #333
Closed

Testing: Upgrade to Junit 5 #332

kmanning opened this issue Feb 2, 2021 · 0 comments · Fixed by #333
Labels
testing Improve the test suite(s)
Milestone
v5.15

Comments

@kmanning
Copy link
Collaborator

kmanning commented Feb 2, 2021 •
edited
Loading

  • Replace HierarchicalContextRunner.class with @Nested, remove junit-hierarchicalcontextrunner dependency
  • Replace @Before/@After, with @BeforeEach/@AfterEach
  • Replace deprecated Junit asserts with Hamcrest matcher asserts
  • Remove/replace @ParameterizedTest
@kmanning kmanning changed the title Upgrade to Junit 5 Testing: Upgrade to Junit 5 Feb 2, 2021
@kmanning kmanning added the testing Improve the test suite(s) label Feb 2, 2021
@kmanning kmanning added this to the v5.15 milestone Feb 2, 2021
@kmanning kmanning mentioned this issue Feb 4, 2021
Merged
@kmanning kmanning linked a pull request Feb 4, 2021 that will close this issue
Issue 332: Upgrade to Junit 5, hamcrest 2.2 #333
Merged
This was referenced Feb 5, 2021
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Improve the test suite(s)
Projects
None yet
Milestone
v5.15
Development

Successfully merging a pull request may close this issue.

Issue 332: Upgrade to Junit 5, hamcrest 2.2 kmanning/terraform-pipeline
1 participant
@kmanning