Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlywayMigrationPlugin: Optionally disable echo for CLI #363

Closed
kmanning opened this issue Apr 14, 2021 · 1 comment · Fixed by #364
Closed

FlywayMigrationPlugin: Optionally disable echo for CLI #363

kmanning opened this issue Apr 14, 2021 · 1 comment · Fixed by #364
Milestone
v5.16

Comments

@kmanning
Copy link
Collaborator

  • I don't want to allow username/password to be passed to the CLI, as it will be echoed to the console output. The initial MVP for There should be a way to apply automated database migrations #21 is to configure username/password through environment variables.
  • As a user, I want to be able to optionally disable echo for the flyway CLI, so that I can safely pass username/password values to the CLI as command line arguments instead of environment variables.
@kmanning kmanning mentioned this issue Apr 14, 2021
Closed
@kmanning kmanning added this to the v5.16 milestone Apr 14, 2021
@kmanning kmanning linked a pull request Apr 14, 2021 that will close this issue
Optionally enable echo on flyway CLI commands #364
Merged
@kmanning kmanning mentioned this issue Apr 14, 2021
Merged
@kmanning
Copy link
Collaborator Author

Let's flip the logic - by default, echo will be disabled, but the user can optionally enable it.

@kmanning kmanning mentioned this issue Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.16
Development

Successfully merging a pull request may close this issue.

Optionally enable echo on flyway CLI commands kmanning/terraform-pipeline
1 participant
@kmanning