Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CredentialsPlugin: deprecate and replace withBuildCredentials #404

Open
kmanning opened this issue Aug 27, 2021 · 0 comments
Open

CredentialsPlugin: deprecate and replace withBuildCredentials #404

kmanning opened this issue Aug 27, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone
v6.0

Comments

@kmanning
Copy link
Collaborator

withBuildCredentials is hardcoded to use usernamePassword. There are multiple credentials bindings - we should support any binding. This means that withBuildCredentials is inappropriately named and not flexible enough.

Issue #214 adds a more flexible solution - withBinding, and deprecated withBuildCredentials.

Let's remove withBuildCredentials in the next major release.
@kmanning kmanning added this to the v6.0 milestone Aug 27, 2021
@kmanning kmanning mentioned this issue Aug 27, 2021
Closed
@kmanning kmanning added the enhancement New feature or request label Feb 3, 2022
@kmanning kmanning changed the title CredentialsPlugin: remove withBuildCredentials CredentialsPlugin: deprecate and replace withBuildCredentials Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v6.0
Development

No branches or pull requests
1 participant
@kmanning