Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsulBackendPlugin - allow environment variable for address #49

Closed
kmanning opened this issue Sep 3, 2019 · 0 comments
Closed

ConsulBackendPlugin - allow environment variable for address #49

kmanning opened this issue Sep 3, 2019 · 0 comments

Comments

@kmanning
Copy link
Collaborator

kmanning commented Sep 3, 2019

  • All of Vipar's terraform currently use Consul as the backend
  • The Consul address is hardcoded across all the projects
  • What if instead, we simply had the ConsulBackendPlugin search for a DEFAULT_CONSUL_ADDRESS environment variable, and inject that as a parameter if found. That would reduce the amount of duplication across all the projects, and make it easier to migrate to a different consul if every necessary.
@kmanning kmanning closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant