Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support File-based parameters #62

Closed
kmanning opened this issue Sep 3, 2019 · 2 comments
Closed

Support File-based parameters #62

kmanning opened this issue Sep 3, 2019 · 2 comments

Comments

@kmanning
Copy link
Collaborator

kmanning commented Sep 3, 2019

  • Some teams simply aren't ready to start storing parameters in ParameterStore
  • ^-- that will likely prevent some teams from using this pipeline until they're ready to use ParameterStore (if ever)
  • Provide the ability to store key/value pairs directly in a file in their project
  • The files should be named after the environment by default
@kmanning
Copy link
Collaborator Author

kmanning commented Sep 3, 2019

Eg:

FileBasedParameters.init()

def validate = new TerraformValidateStage()

// Looks for a qa.properties file, loads contents, and breaks into key/value pairs based on newline
def deployQa = new TerraformEnvironmentStage('qa')

// Looks for a uat.properties file, loads contents, and breaks into key/value pairs based on newline
def deployUat = new TerraformEnvironmentStage('uat')

validate.then(deployQa)
        .then(deployUat)
        .build()

@kmanning
Copy link
Collaborator Author

kmanning commented Sep 3, 2019

Teams should explicitly be discouraged from storing sensitive data in the properties files. Reference users to CredentialsPlugin, Issue #67 .

@kmanning kmanning closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant