Add options #22
Closed
Add options #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 21, 2018 20:55
Implement early stopping for the MERF fitting procedure, based on relative tolerance. The default value has been changed to "None" to reflect that the option will be ignored unless specified.
Attempted to fix formatting for early stopping, so as not to anger the continuous integration.
Add ability to specify additional parameters to RandomForestRegressor, with some minor error checking and two additional tests.
|
@cunningjames This just has some lint errors that need to be fixed. I can take a look at reviewing this tomorrow as well. Thanks for contributing! |
|
@cunningjames I merged another PR with the same feature. I'm gonna go ahead and close this one. v0.3 (which I'm about to release now) will have this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to specify additional parameters to RandomForestRegressor, with some minor error checking and two additional tests.
Options are passed in as dictionary argument rf_opts. n_estimators is ignored in favor of the argument to the constructor; oob_score is ignored and always set to True; warm_start is ignored (assumed to be False).
Two reasons this is helpful for me, at least: the random forest fit is often faster (particularly on my laptop) with n_jobs set to 1. I'm also hoping to investigate the shap interpretability package, but the underlying algorithms perform extremely poorly on deep trees, so the ability to specify max_depth would make that a bit easier.
This is a repeat of another pull request, closed by me, attempting to fix formatting issues that cause continuous integration to fail.