Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't depend on Manim for testing #37

Closed
naveen521kk opened this issue Mar 2, 2021 · 1 comment · Fixed by #61
Closed

Don't depend on Manim for testing #37

naveen521kk opened this issue Mar 2, 2021 · 1 comment · Fixed by #61
Labels
tests about tests
Projects
In near Future
Milestone
v0.3.0

Comments

@naveen521kk
Copy link
Member

Currently, for testing, we require ManimCE to be installed, but that causes a circular dependency even though it is just for testing. My suggestion is not to depend on Manim, instead implement those classes in the test suite.
@naveen521kk naveen521kk added the tests about tests label Mar 6, 2021
@naveen521kk naveen521kk added the good first issue Good for newcomers label Mar 24, 2021
@naveen521kk naveen521kk added this to To do in In near Future via automation Apr 22, 2021
@naveen521kk naveen521kk added this to the v0.2.7 milestone Apr 22, 2021
@naveen521kk
Copy link
Member Author

If we can do this, it should be possible to test on py3.10

@naveen521kk naveen521kk mentioned this issue May 29, 2021
Closed
@naveen521kk naveen521kk removed the good first issue Good for newcomers label May 29, 2021
naveen521kk added a commit that referenced this issue May 31, 2021
@naveen521kk
Don't depend on Manim while testing
55ce5b7 
Also test with python3.10-dev and pypy3
Fixes #37

Signed-off-by: Naveen M K <naveen@syrusdark.website>
@naveen521kk naveen521kk mentioned this issue May 31, 2021
Merged
In near Future automation moved this from To do to Done May 31, 2021
PhilippImhof pushed a commit that referenced this issue May 31, 2021
@naveen521kk
Don't depend on Manim while testing (#61)
7e2b17a 
* Don't depend on Manim while testing
Also test with python3.10-dev and pypy3
Fixes #37

Signed-off-by: Naveen M K <naveen@syrusdark.website>

* fix lint

* Pin correct pytest version
typo

* Ok Cython is broken on py3.10 and pypy
they will fix it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests about tests
Projects
In near Future
Done
Milestone
v0.3.0
1 participant
@naveen521kk