[buildpkg] pkgver() not updating pkgver #198
Comments
By design it does not update unversioned packages. |
What do you mean by an unversioned package? So desktop-settings-community is unversioned? |
Yes, or simply set the version. |
Hold on. Show me the PKGBUILD. With pacman 5.0 the prepare step is done before pkgver. I had to change that also on our calamares-dev PKGBUILD ... |
Right Phil, you can see eg with manjaro-tools-git pkg, it will aöways show you one commit earlier since pacman 5 |
What do you mean with one commit earlier? |
I see no error here:
|
Phil, say you build manjaro-tools-git with makepkg We should change the sed to be _ver rather than the commit. |
Let me check that ... |
Do I miss here some? On my end it is as expected. Latest git commit in devel is: r1979.1dc80fc That is what I got with pkgbuild:
Same as with makepkg:
You simply have to clean your dir before building. |
Now look in the scripts if they have a matching version at the top, eg buildpkg |
Point being, we shouldn't set the version in the scripts to be git, we should set it to manjaro-tools release version. |
It should look like this with git pkg...
|
I think more or less only makepkg will update the PKGVER in PKGBUILD, but not buildpkg. So I don't care about that ... |
right, and its correct only makepkg does it. |
The other thing we can change, if needed. Also for me it doesn't bother if we have to rebuild the chroot for a git-version. Sometimes even needed ... |
Its just changing PKGBUILD. The downside with setting a git commit for chroot version is, that you can't use existing chroot, despite its also being 0.11.3 |
Right, then we change it as needed. But this is connected with the pkg version or how does manjaro-tools check the version? |
The chroot hosts a .manjaro-tools file, that holds the version that is at top of the scripts, and you see displayed on -q switch. |
We should do this, rather than setting pkgver for git pkg...
I use this for my git builds. |
Ok, add it to the PKGBUILD then. |
resulting in errors:
I have to run makepg first to have pkgver update...
The text was updated successfully, but these errors were encountered: