Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing git tags to corresponding pypi releases #49

Open
anthraxx opened this issue Dec 12, 2018 · 10 comments
Open

missing git tags to corresponding pypi releases #49

anthraxx opened this issue Dec 12, 2018 · 10 comments

Comments

@anthraxx
Copy link

Releases published on pypi should also have their corresponding commits tagged in git and published to github for transparency.

Please push missing tags (especially latest)

@mgorny
Copy link

mgorny commented Mar 16, 2023

So apparently @wilhelmer has taken over the PyPI, made a new release but there's no sdist, no git tag, no issue tracker on their fork and all the URLs are pointing back there. Sigh.

@wilhelmer
Copy link

wilhelmer commented Mar 16, 2023

I didn't take over anything 😄 I just created a fork to solve #66 for our own project. I published it as htmlmin2 for technical reasons, but it's not meant as an official successor to htmlmin.

That being said, I just added tags for the last 3 releases 😉

@mgorny
Copy link

mgorny commented Mar 16, 2023

Thank you.

Unfortunately, since your fork is installed as htmlmin (i.e. the same package as the original), it is impossible to install both htmlmin and htmlmin2 on the same system. This in turn means a packaging nightmare where mkdocs-minify-plugin requires htmlmin2 and e.g. flask-htmlmin requires htmlmin. Since they both cannot be installed simultaneously, this now means that mkdocs-minify-plugin cannot be installed simultaneously with any other package using htmlmin.

On top of that, every distribution will probably need to patch htmlmin anyway to resolve the bug in question.

@wilhelmer
Copy link

Oops, didn't know that, thanks for the explanation! So I should rename everything in the fork from htmlmin to htmlmin2 and then use import htmlmin2 in our project?

@mgorny
Copy link

mgorny commented Mar 16, 2023

That's one possibility. Unfortunately, it's not a very good option because we'll effectively have two almost identical htmlmin and htmlmin2 packages, at least unless you decide to actively maintain htmlmin2 and other projects switch to it.

That said, it may be worthwhile to ask maintainers of flask-htmlmin (@hamidfzm) and pelican-minify (@rdegges) if they're interested in co-maintaining a fork.

@mankyd
Copy link
Owner

mankyd commented Mar 16, 2023

Chiming in here in the middle of the workday: I have been negligent in my duties to this project.

I am willing to discuss sharing or handing-over ownership of this project.

I wrote this years ago when I worked on Google's Pagespeed and "fast webpages" was at the forefront of my mind.

I haven't worked on that project - or anything web related even - in almost 8 years. Between work and life responsibilities, this project doesn't get the attention it deserves from me. Couple that with the fact that I am not entirely "proud" of this code anymore, and my motivation to commit time to it is delinquient.

If you're interested, let's find a way to make that work.

@wilhelmer
Copy link

Ah wonderful, hi Dave! 👋

I see two solutions here:

  1. Cherry-pick this commit and release a new version on PyPI, since this is the only change our project is asking for
  2. Give someone else rights to maintain the project, both on GitHub + PyPI.

@mgorny
Copy link

mgorny commented Apr 6, 2023

@mankyd, ping.

@DonDeWitt
Copy link

@mankyd ping

@raratiru
Copy link

@mankyd Yo! Give me a fat beat!

https://youtu.be/YGpR4ceGxW0?feature=shared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants