Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set DiffUtil via Builder, add Adapter.submitList() #18

Closed
wants to merge 1 commit into from

Conversation

P1NG2WIN
Copy link

PLEASE REVIEW AND TEST IT
PLEASE CHECK signingConfigs (RELEASE), I HAD PROBLEMS WITH IT SO COMMENTED IT.

Add ability to set diff util via Builder and later submitList to DiffUtil via new method Adapter.submitList()

PLEASE CHECK signingConfigs (RELEASE), I HAD PROBLEMS WITH IT SO COMMENTED IT.

Add ability to set diff util via Builder and later submitList to DiffUtil via new method Adapter.submitList()
@P1NG2WIN
Copy link
Author

Also it would be cool if you will complete this pr by adding async list differ to your library

@manneohlund
Copy link
Owner

Hi and thanks for your PR @P1NG2WIN!
I'm in a major process of breaking out extensions such as listeners, diff util etc to separate modules and thus self containing extension libraries with their own artifact.
This is a good contribution and i will have a look and see how this will fit in with the new modularization.
Yes i'm aware of the signingConfig issue and will add a fix for that asap.
Stay tuned! 🚀

@manneohlund
Copy link
Owner

I'm closing this PR due to all issues has been addressed in latest v5.x.x releases. Thanks for contributing with issues and ideas!

@manneohlund manneohlund closed this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants