Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Gradle 4.6 #57

Closed
mannodermaus opened this issue Feb 16, 2018 · 3 comments
Closed

Support Gradle 4.6 #57

mannodermaus opened this issue Feb 16, 2018 · 3 comments
Labels
enhancement
Milestone
plugin-1.0.31

Comments

@mannodermaus
Copy link
Owner

mannodermaus commented Feb 16, 2018 •
edited

With Gradle 4.6, native support for JUnit 5 will arrive has arrived. It'll be interesting to see the extent of how this integration can be leveraged on Android as well. Potentially, the plugin would get a major overhaul, splitting up into compat mode (the current implementation, using JavaExec tasks) and native mode (using Test tasks and the improvements in 4.6).
@mannodermaus mannodermaus added this to the plugin-backlog milestone Feb 16, 2018
@mannodermaus
Copy link
Owner Author

It doesn't seem worth it to move to Gradle 4.6 APIs just yet - the integrated support for JUnit Platform isn't up to speed with what the Gradle plugin could do. Since the plugin isn't incompatible with 4.6, let's stick to it for now.

@mannodermaus
Copy link
Owner Author

mannodermaus commented Mar 2, 2018 •
edited

Actually, it is.

Class 'JUnit5UnitTestRunAll' is not abstract and does not implement abstract member
@Incubating @Nested public abstract fun getJvmArgumentProviders(): (Mutable)List<CommandLineArgumentProvider!>!
defined in de.mannodermaus.gradle.plugins.junit5.JUnit5UnitTest

Related

@mannodermaus mannodermaus reopened this Mar 2, 2018
@mannodermaus mannodermaus changed the title Examine Gradle 4.6 integration. Support Gradle 4.6 Mar 2, 2018
@mannodermaus
Copy link
Owner Author

Addressed in 1.0.31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
plugin-1.0.31
Development

No branches or pull requests
1 participant
@mannodermaus