New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SanStorage network latency isn't included to compute Cloudlet's predicted file transfer time #132

Closed
AbderrahmanL opened this Issue May 31, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@AbderrahmanL
Contributor

AbderrahmanL commented May 31, 2018

Expected behavior:

To include network latency when calculating transfer time in the case of SanStorage

Actual behavior :

Not including the latency

Suggestion

Instead of making two methods to get transfer time in both SanStorage and HarddriveStorage (getFileTransferTimePlusNetworkLatency for SanStorage and getTransferTime for HarddriveStorage), making one for HarddriveStorage, and then redefining It In the SanStorage class to take network latency in consideration will make It possible to use that one method directly on FileStorage objects in the predictFileTransferTime method of DatacenterSimple instead of writing new code for that.

@manoelcampos

This comment has been minimized.

Owner

manoelcampos commented May 31, 2018

Hello @AbderrahmanL,

Are you working on this issue? Please let me know.
I've just fixed a critical issue (#135). So I suggest you update your fork, mainly if you are working on the issue you reported.

@AbderrahmanL

This comment has been minimized.

Contributor

AbderrahmanL commented May 31, 2018

Hello @manoelcampos
I'll work on fixing It its just that Im new to contribution Using github been in the microsoft eco systeme for a while so I'll read the contribution guide and follow the guidelines the best i can

@manoelcampos

This comment has been minimized.

Owner

manoelcampos commented May 31, 2018

Ok. Thanks for that.

@manoelcampos manoelcampos changed the title from Cloudlet predicted file transfer time and SanStorage network latency to SanStorage network latency isn't included to compute Cloudlet's predicted file transfer time Jun 27, 2018

@manoelcampos manoelcampos added this to the CloudSim Plus 3.0 milestone Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment