Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incident_angle in single scattering model is not used in scattering calculations #100

Open
victoriahwang89 opened this issue Sep 12, 2020 · 1 comment

Comments

@victoriahwang89
Copy link
Collaborator

Currently, the incident_angle parameter in model.py only changes the Fresnel reflection and transmission coefficients. In order to correctly account for the effect of the incident angle, the single scattering model should apply a rotation matrix to the user-specified integration angles of the differential scattering cross section, such that the integration angles are in the same coordinate system as the incident direction.

@victoriahwang89
Copy link
Collaborator Author

victoriahwang89 commented Sep 12, 2020

Note 1: So far we've always used a normal incident angle in the single scattering model, which is why this issue hasn't come up before.
Note 2: The implementation of the incident angle in montecarlo.py should be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant