You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the incident_angle parameter in model.py only changes the Fresnel reflection and transmission coefficients. In order to correctly account for the effect of the incident angle, the single scattering model should apply a rotation matrix to the user-specified integration angles of the differential scattering cross section, such that the integration angles are in the same coordinate system as the incident direction.
The text was updated successfully, but these errors were encountered:
Note 1: So far we've always used a normal incident angle in the single scattering model, which is why this issue hasn't come up before.
Note 2: The implementation of the incident angle in montecarlo.py should be correct.
Currently, the incident_angle parameter in model.py only changes the Fresnel reflection and transmission coefficients. In order to correctly account for the effect of the incident angle, the single scattering model should apply a rotation matrix to the user-specified integration angles of the differential scattering cross section, such that the integration angles are in the same coordinate system as the incident direction.
The text was updated successfully, but these errors were encountered: