Moved cat "header" to stderr for easier piping #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @juan-riveros - this looks great! I think it's okay to move the header to stderr. The tests seem to be failing though, would you be able to take a look? |
* Changed `validate_cat_csv` since it's predicate assumed that the output would have the extra spacing caused by the header. (ie. removed two empty lines it checked for) * Changed `validate_cat_directory` from checking for the filenames on standard out to checking for filenames on stderr.
|
There that should do it. Had to change two tests since they assumed that the header existed in stdout. One assumed the output would be surrounded by newlines so just removed the newlines from the predicate and the other checked for filenames in stdout so changed it checking against stderr instead. |
|
Awesome. Thanks a lot for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #20 by moving the cat "header" to stderr instead of stdout to allow for piping.
Feel free to reject this if you think that a
--quietflag might be a better option.