Dependencies update + redone commands in clap 3.0 + clippy #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the contribution @mateuszkj. Might take a few days to review since the PR has a lot of changes - hope you don't mind! 😀 |
manojkarthick
approved these changes
May 6, 2022
There was a problem hiding this comment.
Thanks a lot @mateuszkj - this looks great! It would be great if you could take a look at that one specific regression.
| writeln!(f, "Number of records to print: {}", &self.num_records)?; | ||
| writeln!(f, "Use Output format: {}", self.format.to_string())?; | ||
| let file = open_file(&opts.file)?; | ||
| print_rows(file, Some(opts.records), format)?; |
There was a problem hiding this comment.
I was testing with a JSON file and the update seems to introduce a new regression with some files:
Error: ArrowReadWriteError(JsonError("data type Decimal(12, 6) not supported in nested map for json writer"))
Doesn't have an issue with the old implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request has only have:
clap::Parser. I have removed traitPQRSCommandin favor of structs.catandheaduses Json/Csv writers from arrow.All tests passes.
Reason for this MR is it will be easier to add new sub-commands.