Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peripheral: Fix notifications #5

Merged
merged 1 commit into from Feb 4, 2022
Merged

Peripheral: Fix notifications #5

merged 1 commit into from Feb 4, 2022

Conversation

bricklife
Copy link
Contributor

It seems that the following lines are not called even if you set any notify on:

AsyncBluetooth/Sources/Peripheral/Peripheral.swift

Lines 298 to 300 in bc3e0be

self.context.characteristicValueUpdatedSubject.send(
Characteristic(characteristic)
)

I'm not sure if my fix fits your design, but it works fine. I hope this PR is helpful.

@manolofdez manolofdez merged commit e991715 into manolofdez:main Feb 4, 2022
@bricklife bricklife deleted the fix-notifications branch February 4, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bricklife @manolofdez