Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested serializers support #104

Merged
merged 6 commits into from Jun 30, 2016
Merged

Nested serializers support #104

merged 6 commits into from Jun 30, 2016

Conversation

Ivaylo-Bachvarov
Copy link
Contributor

Take a look at this.

We added:

  • An example for nested serializers in the demo app.
  • Support for nested serializer in nested serializer (recursive)
  • User friendly interface for the nested serializer data.

Things that we are going to add in a separate pull request:

  • Support for Nested Serialization in Live API Endpoints.

Authors: Me and @Ivo-Donchev 馃惣 馃嵒

@kdkocev
Copy link

kdkocev commented Jun 22, 2016

馃憤

2 similar comments
@Ivo-Donchev
Copy link

馃憤

@Rositsazz
Copy link

馃憤

@manosim
Copy link
Owner

manosim commented Jun 23, 2016

Hello everyone! Thank you for the PR -looks really good! Can you bring it up to date with master so that we can merge it?

@Ivaylo-Bachvarov
Copy link
Contributor Author

Ivaylo-Bachvarov commented Jun 23, 2016

@ekonstantinidis

Today I will bring it up to date and I will ping you here for a merge.

We are preparing some more PR for that great project 馃嵒

@Ivaylo-Bachvarov
Copy link
Contributor Author

@ekonstantinidis The PR is up to date with master now :)

@manosim
Copy link
Owner

manosim commented Jun 24, 2016

Awesome! It would be great if you can add some tests for this PR at some point?

@Ivaylo-Bachvarov
Copy link
Contributor Author

@ekonstantinidis Upcoming commits with tests and Live API support in this pull request ;)
@Ivo-Donchev will commit soon 馃嵒

@Ivaylo-Bachvarov
Copy link
Contributor Author

@ekonstantinidis I think that we are done with this.

We added support for many=True in nested serializing.

This PR is ready for merge.
Another PR is comming with Live API Support.

@manosim
Copy link
Owner

manosim commented Jun 30, 2016

Hello @Ivaylo-Bachvarov! Sorry for the late reply - been really busy. That looks great so let's merge it!

@manosim manosim merged commit 875a600 into manosim:master Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants