Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding script in template block #110

Merged
merged 1 commit into from Jul 7, 2016
Merged

Allow overriding script in template block #110

merged 1 commit into from Jul 7, 2016

Conversation

limdauto
Copy link
Contributor

@limdauto limdauto commented Jul 6, 2016

Hello,

Thanks for the awesome library. I would like to have the ability to extend the scripts so I'm just wrapping it in a template block. Hope it's ok.

@manosim
Copy link
Owner

manosim commented Jul 6, 2016

Hi @limdauto, sounds like a good idea! Do you think it should be name script or maybe it's better to name it javascript?

@limdauto
Copy link
Contributor Author

limdauto commented Jul 6, 2016

I really don't care :D I usually name it script but if you'd like me to change, I will change it.

@manosim
Copy link
Owner

manosim commented Jul 7, 2016

Well let's go for script then! It's pretty much the same isn't it?

@manosim manosim merged commit 4cb10da into manosim:master Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants