Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2.0 Support #175

Open
psyonara opened this issue Dec 5, 2017 · 16 comments
Open

Django 2.0 Support #175

psyonara opened this issue Dec 5, 2017 · 16 comments

Comments

@psyonara
Copy link

psyonara commented Dec 5, 2017

While trying to upgrade one of my projects to Django 2.0, I received the following error for drf-docs:

File ".../ve3.6/lib/python3.6/site-packages/rest_framework_docs/api_docs.py", line 3, in <module>
    from django.core.urlresolvers import RegexURLResolver, RegexURLPattern
ModuleNotFoundError: No module named 'django.core.urlresolvers'

So far I have not found much about how those classes have been moved/changed in Django's latest versions, so I cannot yet contribute to fix this.

@psyonara
Copy link
Author

psyonara commented Dec 5, 2017

I think I may have found the info I need. Will try to submit a fix for this in the next day or two.

@psyonara
Copy link
Author

psyonara commented Dec 6, 2017

Further error received with Django 2.0:

File "/home/helmut/code/django-rest-framework-docs/demo/project/organisations/models.py", line 32, in Membership
    organisation = models.ForeignKey(Organisation)
TypeError: __init__() missing 1 required positional argument: 'on_delete'

@psyonara
Copy link
Author

psyonara commented Dec 6, 2017

That seems to be on the demo project.

@secret104278
Copy link

Also looking for this problem
Is there any solution to fix it

@psyonara
Copy link
Author

I have started on a fix, but ran into some difficulties that I have not been able to solve yet. Will hopefully get some more time to look at this further in the next week.

@psyonara
Copy link
Author

The problem is that it'll need conditional checks, since the changes in 2.0 that are the issue here are not all present or back-ported in 1.11 and 1.8, which are the two Django versions still being supported.

@yizhang7210
Copy link

@psyonara Would be really nice to have support for Django 2.0. I'm not a super pro but any way I can help?

@rfezzani
Copy link

This is fixed by #177 , I hope it will be merged soon ;-).

@whitedogg13
Copy link

Hi guys, I just created a new lib supporting Django 1.x and 2.x: django-rest-framework-redocs.

It's also a zero configuration automatic API doc page generator, please take a look and help me make it better!

@msmaromi
Copy link

msmaromi commented Jun 4, 2018

wait for this is closed as well

@ggjersund
Copy link

Awaiting merging of #177 and close, anyone working on it?

@pablo0723
Copy link

Any changes, any info when will be merged?

@blairg23
Copy link

I noticed this is still open and also still an issue... any ETA on fix?

@Aameer
Copy link

Aameer commented Sep 24, 2019

+1 on an ETA on this.

@StyXman
Copy link
Contributor

StyXman commented Sep 26, 2019

I'm sorry to bring this up, but this repo is quite unmaintained, more than 2 years since it last merged PR. At some point I stepped in, but I have stopped using it since (change of job). @manosim was quite quick to add me as committer, so if anyone wants to step in...

@pablo0723
Copy link

Same simple version for django 3 and 4 https://pypi.org/project/drfdocs2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests